linux-kernel - Re: [PATCH] drm/vc4: Move IRQ enable to PM path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 30 Dec 2017 21:03:00 +0100 (CET)
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Eric Anholt <eric@...olt.net>, Stefan Schake <stschake@...il.com>,
        linux-kernel@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org
Cc:     linux-rpi-kernel@...ts.infradead.org
Subject: Re: [PATCH] drm/vc4: Move IRQ enable to PM path


> Stefan Schake <stschake@...il.com> hat am 29. Dezember 2017 um 17:05 geschrieben:
> 
> 
> We were calling enable_irq on bind, where it was already enabled previously
> by the IRQ helper. Additionally, dev->irq is not set correctly until after
> postinstall and so was always zero here, triggering a warning in 4.15.
> Fix both by moving the enable to the power management resume path, where we
> know there was a previous disable invocation during suspend.
> 
> Fixes: 253696ccd613 ("drm/vc4: Account for interrupts in flight")
> Signed-off-by: Stefan Schake <stschake@...il.com>

Tested-by: Stefan Wahren <stefan.wahren@...e.com>