linux-kernel - Re: [PATCH net-next 2/2] tuntap: XDP transmission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Jan 2018 12:09:40 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jason Wang <jasowang@...hat.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, mst@...hat.com, jbrouer@...hat.com,
        Jason Wang <jasowang@...hat.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>
Subject: Re: [PATCH net-next 2/2] tuntap: XDP transmission

Hi Jason,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Jason-Wang/XDP-transmission-for-tuntap/20180101-105946
config: i386-randconfig-s1-201800 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   net/socket.o: In function `tun_xdp_to_ptr':
>> net/socket.c:3363: multiple definition of `tun_xdp_to_ptr'
   drivers/vhost/net.o:drivers/vhost/net.c:1026: first defined here
   net/socket.o: In function `tun_ptr_to_xdp':
>> include/linux/if_tun.h:50: multiple definition of `tun_ptr_to_xdp'
   drivers/vhost/net.o:include/linux/if_tun.h:50: first defined here

vim +3363 net/socket.c

ac5a488e Sridhar Samudrala 2006-08-07  3352  
306b13eb Tom Herbert       2017-07-28  3353  int kernel_sendpage_locked(struct sock *sk, struct page *page, int offset,
306b13eb Tom Herbert       2017-07-28  3354  			   size_t size, int flags)
306b13eb Tom Herbert       2017-07-28  3355  {
306b13eb Tom Herbert       2017-07-28  3356  	struct socket *sock = sk->sk_socket;
306b13eb Tom Herbert       2017-07-28  3357  
306b13eb Tom Herbert       2017-07-28  3358  	if (sock->ops->sendpage_locked)
306b13eb Tom Herbert       2017-07-28  3359  		return sock->ops->sendpage_locked(sk, page, offset, size,
306b13eb Tom Herbert       2017-07-28  3360  						  flags);
306b13eb Tom Herbert       2017-07-28  3361  
306b13eb Tom Herbert       2017-07-28  3362  	return sock_no_sendpage_locked(sk, page, offset, size, flags);
306b13eb Tom Herbert       2017-07-28 @3363  }
306b13eb Tom Herbert       2017-07-28  3364  EXPORT_SYMBOL(kernel_sendpage_locked);
306b13eb Tom Herbert       2017-07-28  3365  

:::::: The code at line 3363 was first introduced by commit
:::::: 306b13eb3cf9515a8214bbf5d69d811371d05792 proto_ops: Add locked held versions of sendmsg and sendpage

:::::: TO: Tom Herbert <tom@...ntonium.net>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30355 bytes)