linux-kernel - Re: [PATCH] arch/x86: add __noreturn __cold to fortify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 01 Jan 2018 13:41:55 -0800
From:   Joe Perches <joe@...ches.com>
To:     Joey Pabalinas <joeypabalinas@...il.com>, x86@...nel.org
Cc:     hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch/x86: add __noreturn __cold to fortify_panic()

On Mon, 2018-01-01 at 11:36 -1000, Joey Pabalinas wrote:
> Definition of `fortify_panic()` doesn't match the declaration
> in include/linux/string.h. Add the missing __noreturn __cold
> attributes to `fortify_panic()`.

This should not be necessary as the prototype
has those attributes.

Otherwise, all the __printf attributes would
also have to be added to the definitions and
not the just the declarations.

> Signed-off-by: Joey Pabalinas <joeypabalinas@...il.com>
> ---
>  arch/x86/boot/compressed/misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
> index 98761a1576ceb5c21b..707cf3f339e37f7f8c 100644
> --- a/arch/x86/boot/compressed/misc.c
> +++ b/arch/x86/boot/compressed/misc.c
> @@ -428,7 +428,7 @@ asmlinkage __visible void *extract_kernel(void *rmode, memptr heap,
>  	return output;
>  }
>  
> -void fortify_panic(const char *name)
> +void __noreturn __cold fortify_panic(const char *name)
>  {
>  	error("detected buffer overflow");
>  }