linux-kernel - RE: [PATCH] scsi: megaraid: Use zeroing memory allocator than allocator/memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Jan 2018 16:52:54 +0530
From:   Shivasharan Srikanteshwara 
        <shivasharan.srikanteshwara@...adcom.com>
To:     Himanshu Jha <himanshujha199640@...il.com>,
        martin.petersen@...cle.com, jejb@...ux.vnet.ibm.com
Cc:     Kashyap Desai <kashyap.desai@...adcom.com>,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        "PDL,MEGARAIDLINUX" <megaraidlinux.pdl@...adcom.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        mcgrof@...nel.org
Subject: RE: [PATCH] scsi: megaraid: Use zeroing memory allocator than allocator/memset

> -----Original Message-----
> From: Himanshu Jha [mailto:himanshujha199640@...il.com]
> Sent: Saturday, December 30, 2017 9:18 PM
> To: martin.petersen@...cle.com; jejb@...ux.vnet.ibm.com
> Cc: kashyap.desai@...adcom.com; sumit.saxena@...adcom.com;
> shivasharan.srikanteshwara@...adcom.com;
> megaraidlinux.pdl@...adcom.com; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org; mcgrof@...nel.org; Himanshu Jha
> <himanshujha199640@...il.com>
> Subject: [PATCH] scsi: megaraid: Use zeroing memory allocator than
> allocator/memset
>
> Use pci_zalloc_consistent for allocating zeroed memory and remove
> unnecessary memset function.
>
> Done using Coccinelle.
> Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> 0-day tested with no failures.
>
> Suggested-by: Luis R. Rodriguez <mcgrof@...nel.org>
> Signed-off-by: Himanshu Jha <himanshujha199640@...il.com>
> ---
>  drivers/scsi/megaraid/megaraid_sas_base.c   | 19 ++++++-------------
>  drivers/scsi/megaraid/megaraid_sas_fusion.c |  5 ++---
>  2 files changed, 8 insertions(+), 16 deletions(-)
>

Hi Himanshu,
I can see one more allocation done in megasas_get_seq_num() that could
make use of these changes.
Rest of the changes looks fine.

Also, there is a driver update patchset that I am planning to post today.
Adding this patch first might require additional rebasing of this
patchset.
Would you be ok if I send a separate patch for this along with the change
mentioned above once my patch series gets committed?
That would save me some rebasing effort. :-)

Thanks,
Shivasharan