linux-kernel - Re: [alsa-devel][PATCH v7] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 6 Jan 2018 11:00:01 -0600
From:   Steven Eckhoff <steven.eckhoff.opensource@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
        Philippe Ombredanne <pombredanne@...b.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>
Subject: Re: [alsa-devel][PATCH v7] ASoC: TSCS42xx: Add support for Tempo
 Semiconductor's TSCS42xx audio CODEC

On Fri, Jan 05, 2018 at 12:22:42PM +0000, Mark Brown wrote:

> > +	SOC_ENUM("MBC Band1 Level Detect Switch",
> > +		mbc_level_detection_enums[0]),
> > +	SOC_ENUM("MBC Band2 Level Detect Switch",
> > +		mbc_level_detection_enums[1]),
> > +	SOC_ENUM("MBC Band3 Level Detect Switch",
> > +		mbc_level_detection_enums[2]),
> > +	SOC_ENUM("MBC Band1 Level Detect Win Switch",
> > +		mbc_level_detection_window_enums[0]),
> > +	SOC_ENUM("MBC Band2 Level Detect Win Switch",
> > +		mbc_level_detection_window_enums[1]),
> > +	SOC_ENUM("MBC Band3 Level Detect Win Switch",
> > +		mbc_level_detection_window_enums[2]),
> 
> These are enums so they should probably not have Switch at the end of
> their name, I suspect that might confuse userspace somehow.

v8 will remove Switch from the name.

> > +	SOC_SINGLE("MBC1 Phase Invert", R_DACMBCMUG1, FB_DACMBCMUG1_PHASE,
> > +		1, 0),
> 
> While this is an on/off switch (for inversion) so it ought to end in
> Switch.  Otherwise this driver looks good I think, just those couple of
> small things so I'll apply - please send followup patches fixing.

v8 will add Switch to this.

Thank you again for your time on this.