linux-kernel - Re: [PATCH 03/15] staging: lustre: replace simple cases of LIBCFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 09 Jan 2018 08:39:17 +1100
From:   NeilBrown <neilb@...e.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        lkml <linux-kernel@...r.kernel.org>,
        lustre <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH 03/15] staging: lustre: replace simple cases of LIBCFS_ALLOC with kzalloc.

On Mon, Jan 08 2018, Greg Kroah-Hartman wrote:

> On Mon, Dec 18, 2017 at 11:46:30AM +1100, NeilBrown wrote:
>> All usages of the form
>>   LIBCFS_ALLOC(variable, sizeof(variable))
>> or
>>   LIBCFS_ALLOC(variable, sizeof(variable's-type))
>> 
>> are changed to
>>   variable = kzalloc(sizeof(...), GFP_NOFS);
>> 
>> Similarly, all
>>    LIBCFS_FREE(variable, sizeof(variable))
>> become
>>    kfree(variable);
>> 
>> None of these need the vmalloc option, or any of the other minor
>> benefits of LIBCFS_ALLOC().
>> 
>> Signed-off-by: NeilBrown <neilb@...e.com>
>
> As this broke the kbuild system, I'll stop here in this patch series.
> Can you please fix it up, rebase and resend the remaining ones in this
> series?

Hi Greg,
 thanks for applying the patches.

 That patch had a typo in code that was only included if CONFIG_INFINIBAND is
 enabled, which I didn't have in my testing at the time.  I hadn't
 resent when I fixed it as I was waiting to see if there would be
 feedback.
 If the protocol is "you apply sometime after two weeks if there is no
 feedback (and no breakage)", then I'll aim to work with that.

 I'll resend with the rest of the kmalloc patches.

Thanks,
NeilBrown


 

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)