linux-kernel - Re: [PATCH 0/3] Some small clean-ups in genwqe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 08 Jan 2018 13:57:45 +0100
From:   haver <haver@...ux.vnet.ibm.com>
To:     "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH 0/3] Some small clean-ups in genwqe

Hi Guilherme,

On 2017-12-14 15:34, Guilherme G. Piccoli wrote:
> This patchset is composed by 3 small clean-ups to genwqe
> driver. It aims to improve code clarity, by removing unused
> stuff and make the code follow some conventions.
> 
> It was built and tested against v4.15-rc3, and aims merge
> in v4.16 if possible.
> 
> Thanks in advance!
> 
> Guilherme G. Piccoli (3):
>   genwqe: Remove unused variable and rename function
>   genwqe: Make defines uppercase
>   genwqe: Remove unused parameter in some functions
> 
>  drivers/misc/genwqe/card_base.c    | 16 ++++++++--------
>  drivers/misc/genwqe/card_base.h    | 20 +++++++++-----------
>  drivers/misc/genwqe/card_ddcb.c    | 22 +++++++++++-----------
>  drivers/misc/genwqe/card_debugfs.c |  2 +-
>  drivers/misc/genwqe/card_dev.c     | 19 ++++++++-----------
>  drivers/misc/genwqe/card_utils.c   | 25 +++++++++----------------
>  6 files changed, 46 insertions(+), 58 deletions(-)


Looks ok to me. Thanks for the contribution.
Regards

Frank

Acked-by: Frank Haverkamp <haver@...ux.vnet.ibm.com>