linux-kernel - Re: [PATCH] [v2] ARM: B15: fix unused label warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Jan 2018 14:24:49 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Russell King - ARM Linux <linux@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Brian Norris <computersforpeace@...il.com>,
        Gregory Fong <gregory.0xf0@...il.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [v2] ARM: B15: fix unused label warnings

On Tue, Jan 2, 2018 at 6:33 PM, Russell King - ARM Linux
<linux@...linux.org.uk> wrote:
> On Mon, Dec 18, 2017 at 05:21:24PM -0800, Florian Fainelli wrote:
>> On 12/18/2017 08:52 AM, Arnd Bergmann wrote:
>> > The new conditionally compiled code leaves some labels and one
>> > variable unreferenced when CONFIG_HOTPLUG_CPU and CONFIG_PM_SLEEP
>> > are disabled:
>> >
>> > arch/arm/mm/cache-b15-rac.c: In function 'b15_rac_init':
>> > arch/arm/mm/cache-b15-rac.c:353:1: error: label 'out_unmap' defined but not used [-Werror=unused-label]
>> >  out_unmap:
>> >  ^~~~~~~~~
>> > arch/arm/mm/cache-b15-rac.c:351:1: error: label 'out_cpu_dead' defined but not used [-Werror=unused-label]
>> >  out_cpu_dead:
>> >  ^~~~~~~~~~~~
>> > At top level:
>> > arch/arm/mm/cache-b15-rac.c:53:12: error: 'rac_config0_reg' defined but not used [-Werror=unused-variable]
>> >
>> > This replaces the existing #ifdef conditionals with IS_ENABLED()
>> > checks that let the compiler figure out for itself which code to
>> > drop.
>> >
>> > Fixes: 55de88778f4b ("ARM: 8726/1: B15: Add CPU hotplug awareness")
>> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>
>> Acked-by: Florian Fainelli <f.fainelli@...il.com>
>>
>> Thanks Arnd!
>> --
>> Florian
>
> Arnd, can you throw this at the patch system please?
>
> Note that its now possible to add the "KernelVersion" tag in the email
> headers as well as anywhere in the body.  The difference is that git
> tools can add headers via standard options.

Sent now as 8741/1, sorry for the delay.

      Arnd