linux-kernel - Re: [PATCH 2/3] drivers/fbtft: Remove unnecessary braces from if/else

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Jan 2018 18:03:39 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Luis Gerhorst <linux-kernel@...sgerhorst.de>
Cc:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Jonny Schäfer <schaefer.jonny@...il.com>,
        linux-kernel@...cs.fau.de
Subject: Re: [PATCH 2/3] drivers/fbtft: Remove unnecessary braces from if/else

On Mon, Jan 08, 2018 at 11:06:37AM +0100, Luis Gerhorst wrote:
> The Linux kernel coding style states that braces should only be used
> when necessary.
> 
> This fixes the checkpatch warning
> 
> WARNING: line over 80 characters
> +	} else if (display->regwidth == 8 && display->buswidth == 9 && par->spi) {
> 
> introduced by patch #1.
> 

Don't introduce warnings and then fix them in later patches.

Anyway there is another unwritten rule that multi-line indents get curly
braces.  Probably it should be:


	} else if (display->regwidth == 8 && display->buswidth == 9 &&
		   par->spi) {

regards,
dan carpenter