linux-kernel - [PATCH 5/5] misc/pti: Delete an unnecessary return statement in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 9 Jan 2018 19:33:27 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     kernel-janitors@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH 5/5] misc/pti: Delete an unnecessary return statement in two
 functions

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Tue, 9 Jan 2018 18:52:36 +0100

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected functions.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/misc/pti.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c
index 11d92c3f43ba..7f9235e56cc0 100644
--- a/drivers/misc/pti.c
+++ b/drivers/misc/pti.c
@@ -142,7 +142,6 @@ static void pti_write_to_aperture(struct pti_masterchannel *mc,
 		ptiword |= *p++ << (24-(8*i));
 
 	iowrite32(ptiword, aperture);
-	return;
 }
 
 /**
@@ -390,5 +389,4 @@ void pti_writedata(struct pti_masterchannel *mc, u8 *buf, int count)
 		pti_write_to_aperture(mc, buf, count);
-	return;
 }
 EXPORT_SYMBOL_GPL(pti_writedata);
 
-- 
2.15.1