linux-kernel - Re: [PATCH 4/6] rpmsg: glink: Expose rpmsg name attr for glink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Jan 2018 10:44:13 -0800
From:   Chris Lew <clew@...eaurora.org>
To:     Stephen Boyd <sboyd@...eaurora.org>, bjorn.andersson@...aro.org,
        robh+dt@...nel.org, andy.gross@...aro.org, david.brown@...aro.org
Cc:     aneela@...eaurora.org, linux-arm-msm@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, linux-soc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] rpmsg: glink: Expose rpmsg name attr for glink



On 12/18/2017 2:48 PM, Stephen Boyd wrote:
> On 12/18/2017 02:02 PM, Chris Lew wrote:
>> Expose the name field as an attr so clients listening to uevents for
>> rpmsg can identify the edge the events correspond to.
>>
>> Signed-off-by: Chris Lew <clew@...eaurora.org>
>> ---
>>   drivers/rpmsg/qcom_glink_native.c | 18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>
>> diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
>> index 786f2eca01f1..a897ccea3098 100644
>> --- a/drivers/rpmsg/qcom_glink_native.c
>> +++ b/drivers/rpmsg/qcom_glink_native.c
>> @@ -1558,6 +1558,22 @@ static void qcom_glink_work(struct work_struct *work)
>>   	}
>>   }
>>   
>> +static ssize_t rpmsg_name_show(struct device *dev,
>> +			       struct device_attribute *attr, char *buf)
>> +{
>> +	struct rpmsg_device *rpdev = to_rpmsg_device(dev);
>> +	struct qcom_glink_device *gdev = to_glink_device(rpdev);
>> +
>> +	return snprintf(buf, RPMSG_NAME_SIZE, "%s\n", gdev->glink->name);
>> +}
>> +static DEVICE_ATTR_RO(rpmsg_name);
>> +
>> +static struct attribute *qcom_glink_attrs[] = {
> 
> const?
> 

Thanks Stephen, will change to "static const struct attribute *"

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project