linux-kernel - Re: [PATCH] input: of_touchscreen: add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Jan 2018 11:30:04 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: of_touchscreen: add MODULE_LICENSE

On Wed, Jan 10, 2018 at 05:31:26PM +0100, Arnd Bergmann wrote:
> The lack of the MODULE_LICENSE tag can lead to a warning here:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/input/touchscreen/of_touchscreen.o
> 
> I'm adding a license and description tag, but no MODULE_AUTHOR()
> as this file is a collection of standalone helper functions that
> were all added by different developers.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thank you.

> ---
>  drivers/input/touchscreen/of_touchscreen.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/of_touchscreen.c b/drivers/input/touchscreen/of_touchscreen.c
> index 8d7f9c8f2771..9642f103b726 100644
> --- a/drivers/input/touchscreen/of_touchscreen.c
> +++ b/drivers/input/touchscreen/of_touchscreen.c
> @@ -13,6 +13,7 @@
>  #include <linux/input.h>
>  #include <linux/input/mt.h>
>  #include <linux/input/touchscreen.h>
> +#include <linux/module.h>
>  
>  static bool touchscreen_get_prop_u32(struct device *dev,
>  				     const char *property,
> @@ -185,3 +186,6 @@ void touchscreen_report_pos(struct input_dev *input,
>  	input_report_abs(input, multitouch ? ABS_MT_POSITION_Y : ABS_Y, y);
>  }
>  EXPORT_SYMBOL(touchscreen_report_pos);
> +
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("Device-tree helpers functions for touchscreen devices");
> -- 
> 2.9.0
> 

-- 
Dmitry