linux-kernel - Re: [PATCH V2 5/5] usb: serial: f81534: fix tx error on some baud rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Jan 2018 13:42:32 +0800
From:   "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, peter_hong@...tek.com.tw,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH V2 5/5] usb: serial: f81534: fix tx error on some baud
 rate

Hi Johan,

Johan Hovold 於 2018/1/9 下午 07:32 寫道:
> On Thu, Jan 04, 2018 at 10:29:21AM +0800, Ji-Ze Hong (Peter Hong) wrote:
>> +	/*
>> +	 * We'll make tx frame error when baud rate from 384~500kps. So we'll
>> +	 * delay all tx data frame with 1bit.
>> +	 */
>> +	port_priv->shadow_clk |= F81534_CLK_TX_DELAY_1BIT;
> 
> You don't wan't to enable this only for the affected rates?
> 

This bit will control all transmit TX frame always delay 1 bit
on enabled, but It'll transmit TX frame randomly delay 1 bit on
disabled.

We had tested it with BurnInTest to check the performance,
It'll not make the performance regression. So we'll directly add
it on all baud rate.

Thanks
-- 
With Best Regards,
Peter Hong