linux-kernel - Re: [PATCH] drm/i915/pmu: fix noderef.cocci warnings

Open Source and information security mailing list archives

Date:   Fri, 12 Jan 2018 16:33:25 +0200
From:   Ville Syrjälä <ville.syrjala@...ux.intel.com>
To:     kbuild test robot <fengguang.wu@...el.com>
Cc:     Tvrtko Ursulin <tvrtko.ursulin@...el.com>,
        dri-devel@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
        intel-gfx@...ts.freedesktop.org,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        linux-kernel@...r.kernel.org, kbuild-all@...org,
        Rodrigo Vivi <rodrigo.vivi@...el.com>
Subject: Re: [PATCH] drm/i915/pmu: fix noderef.cocci warnings

On Fri, Jan 12, 2018 at 09:31:16PM +0800, kbuild test robot wrote:
> From: Fengguang Wu <fengguang.wu@...el.com>
> 
> drivers/gpu/drm/i915/i915_pmu.c:795:34-40: ERROR: application of sizeof to pointer
> 
>  sizeof when applied to a pointer typed expression gives the size of
>  the pointer
> 
> Generated by: scripts/coccinelle/misc/noderef.cocci
> 
> Fixes: 109ec558370f ("drm/i915/pmu: Only enumerate available counters in sysfs")
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
> 
>  i915_pmu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/gpu/drm/i915/i915_pmu.c
> +++ b/drivers/gpu/drm/i915/i915_pmu.c
> @@ -792,7 +792,7 @@ create_event_attributes(struct drm_i915_
>  		goto err_alloc;
>  
>  	/* Max one pointer of each attribute type plus a termination entry. */
> -	attr = kzalloc((count * 2 + 1) * sizeof(attr), GFP_KERNEL);
> +	attr = kzalloc((count * 2 + 1) * sizeof(*attr), GFP_KERNEL);

kcalloc()?

>  	if (!attr)
>  		goto err_alloc;
>  
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives