linux-kernel - Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 13 Jan 2018 07:20:23 -0800
From:   Andy Lutomirski <luto@...capital.net>
To:     "Van De Ven, Arjan" <arjan.van.de.ven@...el.com>
Cc:     Andy Lutomirski <luto@...nel.org>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "Raj, Ashok" <ashok.raj@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        David Woodhouse <dwmw@...zon.co.uk>,
        Peter Zijlstra <peterz@...radead.org>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        "Nakajima, Jun" <jun.nakajima@...el.com>,
        "Mallick, Asit K" <asit.k.mallick@...el.com>
Subject: Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl



> On Jan 13, 2018, at 5:52 AM, Van De Ven, Arjan <arjan.van.de.ven@...el.com> wrote:
> 
> 
>>> We were also worried about the indirect calls that are part of the
>>> paravirt interfaces when retpolines are not in place.
>>> 
>> 
>> How could those possibly be any worse than any other indirect call in
>> the kernel?
> 
> they're worse if they happen before you write the MSR that then protects them?

I haven't looked at the latest IBRS code, but I can see only two ways to do it:

1. Write the MSRs from asm.  Get exactly what you expect.

2. Write them from C.  Trust the compiler to be sane.  Failure to optimize asm goto correctly or failure of the paravirt code to patch correctly is very low on the list of things to worry about.