lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 13 Jan 2018 00:33:09 -0600
From:   Matthew Thode <mthode@...ode.org>
To:     David Herrmann <dh.herrmann@...il.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
        Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm
 detection

On 18-01-12 15:07:12, David Herrmann wrote:
> Hi Andy
> 
> On Fri, Jan 12, 2018 at 2:50 PM, Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Fri, Jan 12, 2018 at 1:04 PM, David Herrmann <dh.herrmann@...il.com> wrote:
> >> Cc: Matthew Thode <mthode@...ode.org>
> >
> > Shouldn't be Suggested-by or even Signed-off-by?
> 
> The patch is different (Matthew originally suppressed the ACPI event),
> so I did not copy the sign-off. Please add Suggested-by, if that is an
> acceptable tag.
> 
> >> Signed-off-by: David Herrmann <dh.herrmann@...il.com>
> >
> >
> >> +       case TP_HKEY_EV_PALM_DETECTED:
> >> +       case TP_HKEY_EV_PALM_UNDETECTED:
> >
> >> +               /* palm detected hovering the keyboard, forward to user-space
> >> +                * via netlink for consumption */
> >
> > Comment style is
> > /*
> >  * Multi line comment.
> >  * This is an example.
> >  */
> 
> All other 6 comments in this function follow the style I used here, so
> I tried to be consistent. But feel free to amend this change.
> 

I'm fine with a signed-off-by or tested-by or suggested-by.  There is a
spelling mistake though, 'hoveres' should be hovers.

-- 
Matthew Thode

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux - Powered by OpenVZ