[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5111739c-df33-6a75-5ccf-2a2dc79f015d@ti.com>
Date: Mon, 15 Jan 2018 08:50:38 -0600
From: "Andrew F. Davis" <afd@...com>
To: Mark Brown <broonie@...nel.org>
CC: Liam Girdwood <lgirdwood@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
<alsa-devel@...a-project.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] ASoC: codecs: tas5720: add TAS5722 TDM slot width
setting support
On 12/12/2017 06:02 AM, Mark Brown wrote:
> On Mon, Dec 11, 2017 at 01:01:57PM -0600, Andrew F. Davis wrote:
>
>> + /* Configure TDM slot width. This is only applicable to TAS5722. */
>> + if (tas5720->devtype == TAS5722) {
>> + ret = snd_soc_update_bits(codec, TAS5722_DIGITAL_CTRL2_REG,
>> + TAS5722_TDM_SLOT_16B,
>> + slot_width == 16 ?
>> + TAS5722_TDM_SLOT_16B : 0);
>> + if (ret < 0)
>> + goto error_snd_soc_update_bits;
>> + }
>
> Use a switch statement, that way additional variants can be handled more
> sensibly.
>
Will fix.
Powered by blists - more mailing lists