linux-kernel - Re: [PATCH 04/19] drm/rockchip: Use the alpha format helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Jan 2018 08:42:43 +0800
From:   Sandy Huang <hjc@...k-chips.com>
To:     Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Sean Paul <seanpaul@...omium.org>
Cc:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        thomas@...sch.nl, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 04/19] drm/rockchip: Use the alpha format helper

在 2018/1/9 18:56, Maxime Ripard 写道:
> Now that the core has a drm format helper to tell if a format embeds an
> alpha component in it, let's use it.
> 
> Cc: Mark Yao <mark.yao@...k-chips.com>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 13 +------------
>   1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 19128b4dea54..cfc4d4909185 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -253,17 +253,6 @@ static bool is_yuv_support(uint32_t format)
>   	}
>   }
>   
> -static bool is_alpha_support(uint32_t format)
> -{
> -	switch (format) {
> -	case DRM_FORMAT_ARGB8888:
> -	case DRM_FORMAT_ABGR8888:
> -		return true;
> -	default:
> -		return false;
> -	}
> -}
> -
>   static uint16_t scl_vop_cal_scale(enum scale_mode mode, uint32_t src,
>   				  uint32_t dst, bool is_horizontal,
>   				  int vsu_mode, int *vskiplines)
> @@ -790,7 +779,7 @@ static void vop_plane_atomic_update(struct drm_plane *plane,
>   	rb_swap = has_rb_swapped(fb->format->format);
>   	VOP_WIN_SET(vop, win, rb_swap, rb_swap);
>   
> -	if (is_alpha_support(fb->format->format)) {
> +	if (drm_format_has_alpha(fb->format->format)) {
>   		VOP_WIN_SET(vop, win, dst_alpha_ctl,
>   			    DST_FACTOR_M0(ALPHA_SRC_INVERSE));
>   		val = SRC_ALPHA_EN(1) | SRC_COLOR_M0(ALPHA_SRC_PRE_MUL) |
> 

remove dead email: Mark Yao <mark.yao@...k-chips.com>
Acked-by: Sandy huang <hjc@...k-chips.com>