linux-kernel - Re: [1/2] Revert "mwifiex: cancel pcie/sdio work in remove/shutdown handler"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Jan 2018 16:01:14 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Ganapathi Bhat <gbhat@...vell.com>,
        Nishant Sarmukadam <nishants@...vell.com>,
        Amitkumar Karwar <amitkarwar@...il.com>,
        <linux-kernel@...r.kernel.org>, linux-wireless@...r.kernel.org,
        Ellie Reeves <ellierevves@...il.com>,
        Christoph Hellwig <hch@....de>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Zhiyuan Yang <yangzy@...vell.com>,
        Tim Song <songtao@...vell.com>, Cathy Luo <cluo@...vell.com>,
        James Cao <jcao@...vell.com>,
        Brian Norris <briannorris@...omium.org>,
        "Signed-off-by : Xinming Hu" <huxm@...vell.com>
Subject: Re: [1/2] Revert "mwifiex: cancel pcie/sdio work in remove/shutdown
 handler"

Brian Norris <briannorris@...omium.org> wrote:

> This reverts commit b713bbf1471b56b572ce26bd02b81a85c2b007f4.
> 
> The "fix" in question does not actually fix all related problems, and it
> also introduces new deadlock possibilities. Since commit b014e96d1abb
> ("PCI: Protect pci_error_handlers->reset_notify() usage with
> device_lock()"), the race in question is actually resolved (PCIe reset
> cannot happen at the same time as remove()). Instead, this "fix" just
> introduces a deadlock where mwifiex_pcie_card_reset_work() is waiting on
> device_lock, which is held by PCIe device remove(), which is waiting
> on...mwifiex_pcie_card_reset_work().
> 
> The proper thing to do is just to fix the deadlock. Patch for this will
> come separately.
> 
> Cc: Signed-off-by: Xinming Hu <huxm@...vell.com>
> Signed-off-by: Brian Norris <briannorris@...omium.org>

2 patches applied to wireless-drivers-next.git, thanks.

7e34c0d2f631 Revert "mwifiex: cancel pcie/sdio work in remove/shutdown handler"
a64e7a79dd60 mwifiex: resolve reset vs. remove()/shutdown() deadlocks

-- 
https://patchwork.kernel.org/patch/10161659/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches