linux-kernel - Re: [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 Jan 2018 13:47:38 +0800
From:   "Du, Changbin" <changbin.du@...el.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     "Du, Changbin" <changbin.du@...el.com>,
        Steven Rostedt <rostedt@...dmis.org>, jolsa@...hat.com,
        peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, kernel-team@....com
Subject: Re: [PATCH v3 0/3] tracing: Fix the parser when processing strings
 w/ or w/o terminated '\0'

On Wed, Jan 17, 2018 at 02:45:24PM +0900, Namhyung Kim wrote:
> Hello,
> 
> On Wed, Jan 17, 2018 at 12:54:34PM +0800, Du, Changbin wrote:
> > On Tue, Jan 16, 2018 at 12:42:26PM -0500, Steven Rostedt wrote:
> > > On Tue, 16 Jan 2018 17:02:27 +0800
> > > changbin.du@...el.com wrote:
> > > 
> > > > From: Changbin Du <changbin.du@...el.com>
> > > > 
> > > > I found there are some problems in the tracing parser when I investiage the root
> > > > cause of issues mentioned in below patch.
> > > > https://patchwork.kernel.org/patch/10132953/
> > > 
> > > I pulled in your patches and tweaked the change logs of the other two
> > > patches as well. You can see my temporary git tree here, but it may
> > > rebase.
> > > 
> > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> > > 
> > >  ftrace/core
> > > 
> > > -- Steve
> > Got it. Thank you!
> > 
> > Hi Olsa, so the perf patch 'perf ftrace: Fix the buffer size in__write_tracing_file'
> > is still needed. I will resend you at appropriate time.
> 
> But it will work on the future kernels only, right?  For tools to be
> compatible with old kernels, you'd better writing a whitespace after
> the function name IMHO.
> 
Yes, it needs to write a space if it doesn't want possible error hidden.

> Thanks,
> Namhyung

-- 
Thanks,
Changbin Du