linux-kernel - [PATCH -next] perf: hisi: Remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 17 Jan 2018 11:28:14 +0000
From:   Wei Yongjun <weiyongjun1@...wei.com>
To:     Shaokun Zhang <zhangshaokun@...ilicon.com>
CC:     Wei Yongjun <weiyongjun1@...wei.com>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: [PATCH -next] perf: hisi: Remove redundant dev_err call

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
---
 drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c | 4 +---
 drivers/perf/hisilicon/hisi_uncore_hha_pmu.c | 4 +---
 drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c | 4 +---
 3 file changed, 3 insertion(+), 9 deletions(-)

diff --git a/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c b/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
index 1b10ea0..deb11d2 100644
--- a/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
+++ b/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
@@ -270,10 +270,8 @@ static int hisi_ddrc_pmu_init_data(struct platform_device *pdev,
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	ddrc_pmu->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(ddrc_pmu->base)) {
-		dev_err(&pdev->dev, "ioremap failed for ddrc_pmu resource\n");
+	if (IS_ERR(ddrc_pmu->base))
 		return PTR_ERR(ddrc_pmu->base);
-	}
 
 	return 0;
 }
diff --git a/drivers/perf/hisilicon/hisi_uncore_hha_pmu.c b/drivers/perf/hisilicon/hisi_uncore_hha_pmu.c
index 443906e..dbf7629 100644
--- a/drivers/perf/hisilicon/hisi_uncore_hha_pmu.c
+++ b/drivers/perf/hisilicon/hisi_uncore_hha_pmu.c
@@ -263,10 +263,8 @@ static int hisi_hha_pmu_init_data(struct platform_device *pdev,
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	hha_pmu->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(hha_pmu->base)) {
-		dev_err(&pdev->dev, "ioremap failed for hha_pmu resource\n");
+	if (IS_ERR(hha_pmu->base))
 		return PTR_ERR(hha_pmu->base);
-	}
 
 	return 0;
 }
diff --git a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
index 0bde5d9..8d79d88 100644
--- a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
+++ b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
@@ -266,10 +266,8 @@ static int hisi_l3c_pmu_init_data(struct platform_device *pdev,
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	l3c_pmu->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(l3c_pmu->base)) {
-		dev_err(&pdev->dev, "ioremap failed for l3c_pmu resource\n");
+	if (IS_ERR(l3c_pmu->base))
 		return PTR_ERR(l3c_pmu->base);
-	}
 
 	return 0;
 }