linux-kernel - Re: [PATCH 1/2] microblaze: fix endian handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 Jan 2018 13:57:51 +0100
From:   Michal Simek <monstr@...str.eu>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     kbuild test robot <lkp@...el.com>, kbuild-all@...org,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Babu Moger <babu.moger@...cle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] microblaze: fix endian handling

On 15.1.2018 11:19, Arnd Bergmann wrote:
> On Mon, Jan 15, 2018 at 11:14 AM, Michal Simek <monstr@...str.eu> wrote:
>> On 15.1.2018 10:29, Arnd Bergmann wrote:
>>> On Sun, Jan 14, 2018 at 2:01 AM, kbuild test robot <lkp@...el.com> wrote:
>>>> Hi Arnd,
>>>>
>>>> I love your patch! Yet something to improve:
>>>>
>>>> [auto build test ERROR on linus/master]
>>>> [also build test ERROR on v4.15-rc7 next-20180112]
>>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>>>
>>>> url:    https://github.com/0day-ci/linux/commits/Arnd-Bergmann/microblaze-fix-endian-handling/20180105-120705
>>>> config: microblaze-mmu_defconfig (attached as .config)
>>>> compiler: microblaze-linux-gcc (GCC) 7.2.0
>>>> reproduce:
>>>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>>         chmod +x ~/bin/make.cross
>>>>         # save the attached .config to linux build tree
>>>>         make.cross ARCH=microblaze
>>>>
>>>> All errors (new ones prefixed by >>):
>>>>
>>>>>> arch/microblaze/lib/fastcopy.S:33:2: error: #error Microblaze LE not support ASM optimized lib func. Disable OPT_LIB_ASM.
>>>>     #error Microblaze LE not support ASM optimized lib func. Disable OPT_LIB_ASM.
>>>>      ^~~~~
>>>>
>>>> vim +33 arch/microblaze/lib/fastcopy.S
>>>>
>>>
>>> This seems to be a result of fixing one bug so we run into one that we didn't
>>> get to earlier. I still assume my patch is correct.
>>
>> I will look at this later this week. Xilinx toolchain which I use
>> normally are microblaze for BE or microblazeel that's why proper flags
>> are default options already that's why I didn't see any issue.
>>
>> Did you take toolchain from kernel.org?
>> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/
> 
> I used a gcc-7.2.1 that I built myself for all architectures in order to debug
> a gcc issue that appeared in gcc-7.2.
> 
> The patch that got tested was my workaround for an obviously broken
> allmodconfig build.

ok.

Applied both.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs




Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)