linux-kernel - Re: [PATCH 02/19] staging: lustre: discard SVC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Jan 2018 15:26:48 +0000 (GMT)
From:   James Simmons <jsimmons@...radead.org>
To:     NeilBrown <neilb@...e.com>
cc:     Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        lkml <linux-kernel@...r.kernel.org>,
        lustre <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH 02/19] staging: lustre: discard SVC_SIGNAL and related
 functions


> This flag is never set, so remove checks and remove
> the flag.

Reviewed-by: James Simmons <jsimmons@...radead.org>
 
> Signed-off-by: NeilBrown <neilb@...e.com>
> ---
>  drivers/staging/lustre/lustre/include/lustre_net.h |    6 ------
>  drivers/staging/lustre/lustre/ptlrpc/sec_gc.c      |    4 +---
>  2 files changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/lustre_net.h b/drivers/staging/lustre/lustre/include/lustre_net.h
> index 3ff5de4770e8..4c665eca2467 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_net.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_net.h
> @@ -1260,7 +1260,6 @@ enum {
>  	SVC_STARTING    = 1 << 2,
>  	SVC_RUNNING     = 1 << 3,
>  	SVC_EVENT       = 1 << 4,
> -	SVC_SIGNAL      = 1 << 5,
>  };
>  
>  #define PTLRPC_THR_NAME_LEN		32
> @@ -1333,11 +1332,6 @@ static inline int thread_is_event(struct ptlrpc_thread *thread)
>  	return !!(thread->t_flags & SVC_EVENT);
>  }
>  
> -static inline int thread_is_signal(struct ptlrpc_thread *thread)
> -{
> -	return !!(thread->t_flags & SVC_SIGNAL);
> -}
> -
>  static inline void thread_clear_flags(struct ptlrpc_thread *thread, __u32 flags)
>  {
>  	thread->t_flags &= ~flags;
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c b/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c
> index 8d1e0edfcede..d85c8638c009 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c
> @@ -153,7 +153,6 @@ static int sec_gc_main(void *arg)
>  	while (1) {
>  		struct ptlrpc_sec *sec;
>  
> -		thread_clear_flags(thread, SVC_SIGNAL);
>  		sec_process_ctx_list();
>  again:
>  		/* go through sec list do gc.
> @@ -184,8 +183,7 @@ static int sec_gc_main(void *arg)
>  		lwi = LWI_TIMEOUT(msecs_to_jiffies(SEC_GC_INTERVAL * MSEC_PER_SEC),
>  				  NULL, NULL);
>  		l_wait_event(thread->t_ctl_waitq,
> -			     thread_is_stopping(thread) ||
> -			     thread_is_signal(thread),
> +			     thread_is_stopping(thread),
>  			     &lwi);
>  
>  		if (thread_test_and_clear_flags(thread, SVC_STOPPING))
> 
> 
>