linux-kernel - Re: [PATCH] drm: i915: remove timeval users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 17 Jan 2018 16:47:21 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Chris Wilson <chris@...is-wilson.co.uk>
Cc:     Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        David Airlie <airlied@...ux.ie>,
        Arnd Bergmann <arnd@...db.de>, Daniel Vetter <daniel.vetter@...ll.ch>, Tvrtko Ursulin <tvrtko.ursulin@...el.com>, Ville Syrjälä <ville.syrjala@...ux.intel.com>, Robert Bragg <robert@...bynine.org>, Mahesh Kumar <mahesh1.kumar@...el.com>, Michal Wajdeczko <michal.wajdeczko@...el.com>, Matthew Auld <matthew.auld@...el.com>, Mika Kuoppala <mika.kuoppala@...ux.intel.com>, intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: i915: remove timeval users

On Mon, Nov 6, 2017 at 1:29 PM, Chris Wilson <chris@...is-wilson.co.uk> wrote:
> Quoting Arnd Bergmann (2017-11-03 19:53:52)
>> struct timeval is deprecated because it cannot represent times
>> past 2038. In this driver, the only use of this structure is
>> to capture debug information. This is easily changed to ktime_t,
>> which we then format as needed when printing it later.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>

I just noticed this hasn't gone in yet.

>> +                  (s64)ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC);
>> +       ts = ktime_to_timespec64(error->boottime);
>> +       err_printf(m, "Boottime: %lld s %ld us\n",
>> +                  (s64)ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC);
>> +       ts = ktime_to_timespec64(error->uptime);
>> +       err_printf(m, "Uptime: %lld s %ld us\n",
>> +                  (s64)ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC);
>
> We could just change it to ns, nothing that I know of parses those field
> except us robots. (It's just to try and alert us in case this hang is
> likely following a device reset.)

Right, but it is used in a sysfs file, so I think it's better to not
change it. The i915_error_state_to_str() function is only called
when we actually look at the output, so it's not performance
critical.

> Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>

Thanks! I'll resend the patch unchanged in case it helps getting
it in now.

       Arnd