linux-kernel - Re: [PATCH-next] init/main.c: make local symbol static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30828c91-a39d-6342-2774-32386baa30b6@amd.com>
Date:   Thu, 18 Jan 2018 16:31:17 -0600
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Christopher Díaz Riveros <chrisadr@...too.org>,
        mingo@...nel.org, akpm@...ux-foundation.org, tglx@...utronix.de,
        keescook@...omium.org, lauraa@...eaurora.org, rostedt@...dmis.org,
        mhocko@...e.com, tal.shorer@...il.com, viresh.kumar@...aro.org,
        lokeshvutla@...com
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH-next] init/main.c: make local symbol static

On 1/18/2018 4:09 PM, Randy Dunlap wrote:
> On 01/18/2018 02:06 PM, Christopher Díaz Riveros wrote:
>> Fixes the following sparse warning:
>>
>> init/main.c:167:12: warning:
>>   symbol 'envp_init' was not declared. Should it be static?
>>
>> Signed-off-by: Christopher Díaz Riveros <chrisadr@...too.org>
> 
> Does the kernel build OK after this change?
> 
> What about the other user(s) of envp_init?

It looks like it's referenced in init/do_mounts_initrd.c.  Rather
than making it static, it should be declared in .h file.

Thanks,
Tom

> 
> 
>> ---
>>  init/main.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/init/main.c b/init/main.c
>> index a8100b954839..ae86addb306c 100644
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -164,7 +164,7 @@ static int __init set_reset_devices(char *str)
>>  __setup("reset_devices", set_reset_devices);
>>  
>>  static const char *argv_init[MAX_INIT_ARGS+2] = { "init", NULL, };
>> -const char *envp_init[MAX_INIT_ENVS+2] = { "HOME=/", "TERM=linux", NULL, };
>> +static const char *envp_init[MAX_INIT_ENVS+2] = { "HOME=/", "TERM=linux", NULL, };
>>  static const char *panic_later, *panic_param;
>>  
>>  extern const struct obs_kernel_param __setup_start[], __setup_end[];
>>
> 
>