linux-kernel - Re: [PATCH] Support intel-vbtn based tablet mode switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Jan 2018 16:46:40 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Marco Martin <notmart@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Matthew Garrett <mjg59@...f.ucam.org>,
        Pali Rohár <pali.rohar@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Bhushan Shah <bhush94@...il.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Mario Limonciello <mario.limonciello@...l.com>,
        Mario Limonciello <mario_limonciello@...l.com>
Subject: Re: [PATCH] Support intel-vbtn based tablet mode switch

On Mon, Jan 22, 2018 at 3:52 PM, Marco Martin <notmart@...il.com> wrote:
> On Mon, Jan 22, 2018 at 2:42 PM, Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:

>>> +               if (obj && obj->type == ACPI_TYPE_INTEGER) {
>>> +                       if (obj->integer.value & TABLET_MODE_FLAG)
>>> +                               input_report_switch(priv->input_dev,
>>
>>> +                                                       SW_TABLET_MODE,
>>> +                                                       0);
>>
>> One line?
>
> checkpatch.pl was complaining about lines too long.

My mailer is using true type fonts, so, I don't see clearly an
indentation here, if you already moved SW_ under priv-> that's fine to
leave, otherwise, just move one tab left the entire line.

-- 
With Best Regards,
Andy Shevchenko