linux-kernel - Re: [PATCH 2/3] mfd/sm501: Improve a size determination in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Jan 2018 15:47:33 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] mfd/sm501: Improve a size determination in two
 functions

On Mon, 15 Jan 2018, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 15 Jan 2018 15:47:03 +0100
> 
> Replace the specification of data structures by pointer dereferences
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/mfd/sm501.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index 7298d6b571a1..d5ab3481794a 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -1380,10 +1380,9 @@ static int sm501_init_dev(struct sm501_devdata *sm)
>  
>  static int sm501_plat_probe(struct platform_device *dev)
>  {
> -	struct sm501_devdata *sm;
>  	int ret;
> +	struct sm501_devdata *sm = kzalloc(sizeof(*sm), GFP_KERNEL);
>  
> -	sm = kzalloc(sizeof(struct sm501_devdata), GFP_KERNEL);

Leave this here please.

Just s/struct sm501_devdata/*sm/

>  	if (sm == NULL) {
>  		ret = -ENOMEM;
>  		goto err1;
> @@ -1569,10 +1568,9 @@ static struct sm501_platdata sm501_pci_platdata = {
>  static int sm501_pci_probe(struct pci_dev *dev,
>  				     const struct pci_device_id *id)
>  {
> -	struct sm501_devdata *sm;
>  	int err;
> +	struct sm501_devdata *sm = kzalloc(sizeof(*sm), GFP_KERNEL);
>  
> -	sm = kzalloc(sizeof(struct sm501_devdata), GFP_KERNEL);

As above.

>  	if (sm == NULL) {
>  		err = -ENOMEM;
>  		goto err1;

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog