linux-kernel - Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Jan 2018 20:42:04 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "joe@...ches.com" <joe@...ches.com>,
        "jthumshirn@...e.de" <jthumshirn@...e.de>,
        "axboe@...com" <axboe@...com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>
Subject: Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros

On Mon, 2018-01-22 at 12:23 -0800, Joe Perches wrote:
> On Mon, 2018-01-22 at 08:53 +0100, Johannes Thumshirn wrote:
> > Use pr_debug instead of hand crafted macros. This way it is not needed to
> > re-compile the kernel to enable bsg debug outputs and it's possible to
> > selectively enable specific prints.
> 
> Perhaps better to use
> 
> #define bsg_dbg(bd, fmt, ...) \
> 	pr_debug(bd->name, fmt, ##__VA_ARGS__)

Hello Joe,

Why do you think that would be better?

Thanks,

Bart.