linux-kernel - Re: [PATCH] perf tools: Fixing uninitialised variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Jan 2018 13:36:25 -0600
From:   Kim Phillips <kim.phillips@....com>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:     acme@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: Fixing uninitialised variable

On Mon, 22 Jan 2018 15:17:40 -0700
Mathieu Poirier <mathieu.poirier@...aro.org> wrote:

> When working natively on arm64 the compiler gets pesky and complains

FWIW, I've only seen this on ARCH=arm64 builds with gcc versions less
than 5, i.e, 4.8.5.

> that variable 'i' is uninitialised, something that breaks the
> compilation.

It'd be nice to include the full compiler error message, to help users
searching for how to fix the error.

>  Here no further checks are needed since variable 'found_spe'
> can only be true if variable 'i' has been initialised as part of the for
> loop.
> 
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> ---

Cc'ing me and adding a:

Fixes: ffd3d18c20b8 ("perf tools: Add ARM Statistical Profiling Extensions (SPE) support")

line would also be nice.

Other than those nits:

Acked-by: Kim Phillips <kim.phillips@....com>

Thanks!

Kim