lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Jan 2018 11:47:02 +1100 From: Michael Ellerman <mpe@...erman.id.au> To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>, Benjamin Herrenschmidt <benh@...nel.crashing.org> Cc: "Gustavo A. R. Silva" <garsilva@...eddedor.com>, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] drivers/macintosh: Use true for boolean value "Gustavo A. R. Silva" <gustavo@...eddedor.com> writes: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> > --- > drivers/macintosh/windfarm_pm72.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This seems to be common across all those drivers. Can you please send one patch to fix them all to use bool: $ git grep "started = " drivers/macintosh/ drivers/macintosh/therm_adt746x.c: int started = 0; drivers/macintosh/therm_adt746x.c: started = 1; drivers/macintosh/windfarm_pm112.c: slots_started = 1; drivers/macintosh/windfarm_pm112.c: started = 1; drivers/macintosh/windfarm_pm121.c: pm121_started = 1; drivers/macintosh/windfarm_pm72.c: started = 1; drivers/macintosh/windfarm_pm81.c: wf_smu_started = 1; drivers/macintosh/windfarm_pm91.c: wf_smu_started = 1; drivers/macintosh/windfarm_rm31.c: started = 1; cheers
Powered by blists - more mailing lists