linux-kernel - Re: [PATCH 07/14] MIPS: memblock: Mark present sparsemem sections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Jan 2018 10:27:43 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Marcin Nowakowski <marcin.nowakowski@...s.com>
Cc:     ralf@...ux-mips.org, miodrag.dinic@...s.com, jhogan@...nel.org,
        goran.ferenc@...s.com, david.daney@...ium.com,
        paul.gortmaker@...driver.com, paul.burton@...s.com,
        alex.belits@...ium.com, Steven.Hill@...ium.com,
        alexander.sverdlin@...ia.com, matt.redfearn@...s.com,
        kumba@...too.org, James.hogan@...s.com, Peter.Wotton@...s.com,
        Sergey.Semin@...latforms.ru, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/14] MIPS: memblock: Mark present sparsemem sections

Hello Marcin

On Wed, Jan 24, 2018 at 07:13:03AM +0100, Marcin Nowakowski <marcin.nowakowski@...s.com> wrote:
> Hi Serge,
> 
> On 17.01.2018 23:23, Serge Semin wrote:
> >If sparsemem is activated all sections with present pages must
> >be accordingly marked after memblock is fully initialized.
> >
> >Signed-off-by: Serge Semin <fancer.lancer@...il.com>
> >---
> >  arch/mips/kernel/setup.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> >diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> >index b121fa702..6df1eaf38 100644
> >--- a/arch/mips/kernel/setup.c
> >+++ b/arch/mips/kernel/setup.c
> >@@ -778,7 +778,7 @@ static void __init request_crashkernel(struct resource *res)
> >  static void __init arch_mem_init(char **cmdline_p)
> >  {
> >-	struct memblock_region *reg;
> >+	struct memblock_region *reg __maybe_unused;
> 
> nit: reg is used here. It becomes __maybe_unused in patch 8.
> 

Right. I'll move __maybe_unused change to the patch 8.

-Sergey

> 
> Marcin