linux-kernel - [PATCH v4 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Jan 2018 20:29:42 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Thayer <michael.thayer@...cle.com>,
        Alexander Viro <viro@...iv.linux.org.uk>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Christoph Hellwig <hch@...radead.org>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: [PATCH v4 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support

Hi All,

As mentioned in the v2 cover letter, now that the vboxguest driver which the
vboxsf (guest shared folder) fs driver depends on is queued for merging into
4.16 in char-misc-next, all the dependencies for the vboxsf are in place.

So now its time to work towards also getting vboxsf merged.

This version addresses (AFAIK) all comments made in response to v2.

Changes in v4:
 -Drop "name=..." mount option, instead use the dev_name argument to the
  mount syscall, to keep compatibility with existing fstab entries
 -Fix "nls=%" match_table_t entry to "nls=%s"

Changes in v3:
 -Use text only mount options, instead of a custom data struct
 -Stop caching full path in inode data, if parents gets renamed it will change
 -Fixed negative dentries handling
 -Dropped the force_reread flag for dirs, not sure what it was actually for
  but it is no good, doing a re-read on unlink of a file will lead to
  another file being skipped if the caller has already iterated over the
  entry for the unlinked file.
 -Use file_inode(), file_dentry() and d_inode() helpers
 -Prefix any non object-private symbols with vboxsf_ so as to not pollute
  the global namespace when builtin
 -Add MAINTAINERS entry
 -Misc. cleanups

Changes in v2:
 -Removed various unused wrapper functions
 -Don't use i_private, instead defined alloc_inode and destroy_inode
  methods and use container_of.
 -Drop obsolete comment referencing people to
  http://www.atnf.csiro.au/people/rgooch/linux/vfs.txt
 -move the single symlink op of from lnkops.c to file.c
 -Use SPDX license headers
 -Replace SHFLROOT / SHFLHANDLE defines with normal types
 -Removed unnecessary S_ISREG checks
 -Got rid of bounce_buffer in regops, instead add a "user" flag to 
  vboxsf_read / vboxsf_write, re-using the existing __user address support
  in the vboxguest module
 -Make vboxsf_wrappers return regular linux errno values
 -Use i_size_write to update size on writing
 -Convert doxygen style comments to kerneldoc style comments

Please review.

Regards,

Hans