linux-kernel - Re: [RFC PATCH 0/2] check I2C device id for pca984x chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Jan 2018 17:33:29 +0100
From:   Adrian Fiergolski <Adrian.Fiergolski@...n.ch>
To:     Peter Rosin <peda@...ntia.se>
CC:     Wolfram Sang <wsa@...-dreams.de>, <linux-i2c@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 0/2] check I2C device id for pca984x chips

Hi Peter,

Sorry for the late reply.

Yes, it's true I have one of the chip. However, my yocto based build system
depends on https://github.com/Xilinx/linux-xlnx and it's in version
4.9.0-xilinx-v2017.3.
Apparently, there were some bigger changes in i2c core between this
version and
upstream, thus your patches don't apply.

Next week I will try to align only me i2c subdirectory with upstream.
Provided it compiles, I will
try then to apply and confirm your patches.

Regards,
Adrian

On 22.01.2018 at 12:36, Peter Rosin wrote:
> Hi!
>
> This series tries to check the I2C device id, but instead of open
> coding the check in the pca954x driver, I have a new function in
> the core doing the work.
>
> The code is only compile-tested, hence the RFC, and I would really
> like a Tested-by: tag from Adrian who presumably have one of these
> chips.
>
> Also, I'm not sure if I should list all manufacturers that I know
> about in the header, or if I should settle for the one that is
> actually used and leave the others to be added by whomever needs
> them...
>
> Cheers,
> peda
>
> Peter Rosin (2):
>   i2c: add i2c_get_device_id() to get the standard i2c device id
>   i2c: mux: pca954x: verify the device id of the pca984x chips
>
>  drivers/i2c/i2c-core-base.c         | 33 ++++++++++++++++++++++++++++
>  drivers/i2c/muxes/i2c-mux-pca954x.c | 43 +++++++++++++++++++++++++++++++++++++
>  include/linux/i2c.h                 | 30 ++++++++++++++++++++++++++
>  3 files changed, 106 insertions(+)
>