linux-kernel - Re: [PATCH] IB/cxgb3: remove cxio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 28 Jan 2018 14:09:03 -0700
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Joe Perches <joe@...ches.com>
Cc:     Corentin Labbe <clabbe@...libre.com>, dledford@...hat.com,
        hal.rosenstock@...il.com, sean.hefty@...el.com, swise@...lsio.com,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH] IB/cxgb3: remove cxio_dbg.c

On Sun, Jan 28, 2018 at 08:24:22AM -0800, Joe Perches wrote:
> On Sun, 2018-01-28 at 15:11 +0000, Corentin Labbe wrote:
> > cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: cleanups")
> > 10 years after, we could remove it.
> 
> OK, now you could remove the prototypes and probably
> CONFIG_INFINIBAND_CXGB3_DEBUG too.
> 
> There is a DEBUG test and many uses of pr_debug
> that would have modified behavior.
> 
> The pr_debug uses would only be emitted via a
> dynamic_debug enable and the #ifdef DEBUG is
> probably not necessary or useful as it guards
> a BUG_ON.
> 
>  drivers/infiniband/hw/cxgb3/Kconfig    | 9 ---------
>  drivers/infiniband/hw/cxgb3/Makefile   | 2 --
>  drivers/infiniband/hw/cxgb3/cxio_hal.h | 9 ---------
>  drivers/infiniband/hw/cxgb3/iwch_cq.c  | 7 -------
>  4 files changed, 27 deletions(-)

Yes, can you resend the patch with Joe's hunks as well?

Thanks,
Jason