linux-kernel - Re: [PATCH v2 13/19] drm/sun4i: backend: Set a default zpos in our reset hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Jan 2018 09:53:52 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:     Daniel Vetter <daniel.vetter@...el.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Sean Paul <seanpaul@...omium.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        thomas@...sch.nl
Subject: Re: [PATCH v2 13/19] drm/sun4i: backend: Set a default zpos in our
 reset hook

On Mon, Jan 22, 2018 at 6:35 PM, Maxime Ripard
<maxime.ripard@...e-electrons.com> wrote:
> The our plane state zpos value will be set only if there's an existing

      ^^^ extra word

Otherwise,

Acked-by: Chen-Yu Tsai <wens@...e.org>

> state attached to the plane when creating the property.
>
> However, this is not the case during the probe, and we therefore need to
> put our default value in our reset hook.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> ---
>  drivers/gpu/drm/sun4i/sun4i_layer.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
> index c448cb6b9fa9..03549646528a 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_layer.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
> @@ -28,6 +28,7 @@ struct sun4i_plane_desc {
>
>  static void sun4i_backend_layer_reset(struct drm_plane *plane)
>  {
> +       struct sun4i_layer *layer = plane_to_sun4i_layer(plane);
>         struct sun4i_layer_state *state;
>
>         if (plane->state) {
> @@ -43,6 +44,7 @@ static void sun4i_backend_layer_reset(struct drm_plane *plane)
>         if (state) {
>                 plane->state = &state->state;
>                 plane->state->plane = plane;
> +               plane->state->zpos = layer->id;
>         }
>  }
>
> --
> git-series 0.9.1