linux-kernel - RE: [PATCH v7] Support intel-vbtn based tablet mode switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 29 Jan 2018 19:35:09 +0000
From:   <Mario.Limonciello@...l.com>
To:     <andy.shevchenko@...il.com>, <notmart@...il.com>
CC:     <platform-driver-x86@...r.kernel.org>, <andy@...radead.org>,
        <pali.rohar@...il.com>, <dvhart@...radead.org>,
        <mjg59@...f.ucam.org>, <linux-kernel@...r.kernel.org>,
        <bhush94@...il.com>
Subject: RE: [PATCH v7] Support intel-vbtn based tablet mode switch

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> Sent: Monday, January 29, 2018 12:57 PM
> To: Marco Martin <notmart@...il.com>
> Cc: Platform Driver <platform-driver-x86@...r.kernel.org>; Limonciello, Mario
> <Mario_Limonciello@...l.com>; Andy Shevchenko <andy@...radead.org>; Pali
> Rohár <pali.rohar@...il.com>; Darren Hart <dvhart@...radead.org>; Matthew
> Garrett <mjg59@...f.ucam.org>; Linux Kernel Mailing List <linux-
> kernel@...r.kernel.org>; Bhushan Shah <bhush94@...il.com>
> Subject: Re: [PATCH v7] Support intel-vbtn based tablet mode switch
> 
> On Sat, Jan 27, 2018 at 6:35 PM, Marco Martin <notmart@...il.com> wrote:
> > Some laptops such as Dell Inspiron 7000 series have the
> > tablet mode switch implemented in Intel ACPI,
> > the events to enter and exit the tablet mode are 0xCC and 0xCD
> >
> 
> It doesn't apply :-(

Marco, I can see it applies on 4.15 but it's not applying on platform-drivers-x86/testing.  
It's most likely this commit you need to rebase on top of:

commit 1c3fdf125ef416227e43fdedf6b5097c41e8c467
Author: Darren Hart (VMware) <dvhart@...radead.org>
Date:   Fri Dec 8 14:57:54 2017 -0800

    platform/x86: intel-vbtn: Simplify autorelease logic
    
    The new notify_handler logic determining if autorelease should be used or
    not is a bit awkward, and can result in more than one call to
    sparse_keymap_report_event for the same event (scancode). The nesting
    and long lines also made it difficult to read.
    
    Simplify the logic by eliminating a level of nesting with a goto and
    always calculate autorelease and val so we can make a single call to
    sparse_keymap_report_event.
    
    Signed-off-by: Darren Hart (VMware) <dvhart@...radead.org>
    Reviewed-by: Stefan Brüns <stefan.bruens@...h-aachen.de>
    Tested-by: Stefan Brüns <stefan.bruens@...h-aachen.de>
    Cc: AceLan Kao <acelan.kao@...onical.com>

> 
> > CC: platform-driver-x86@...r.kernel.org
> > CC: Matthew Garrett <mjg59@...f.ucam.org>
> > CC: "Pali Rohár" <pali.rohar@...il.com>
> > CC: Darren Hart <dvhart@...radead.org>
> > CC: Mario Limonciello <mario_limonciello@...l.com>
> > CC: Andy Shevchenko <andy@...radead.org>
> >
> > Signed-off-by: Marco Martin <notmart@...il.com>
> >
> > Reviewed-by: Mario Limonciello <mario.limonciello@...l.com>
> > Acked-by: Pali Rohár <pali.rohar@...il.com>
> > ---
> >  drivers/platform/x86/intel-vbtn.c | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >
> > diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> > index 58c5ff3..0979811 100644
> > --- a/drivers/platform/x86/intel-vbtn.c
> > +++ b/drivers/platform/x86/intel-vbtn.c
> > @@ -26,6 +26,9 @@
> >  #include <linux/suspend.h>
> >  #include <acpi/acpi_bus.h>
> >
> > +/* When NOT in tablet mode, VGBS returns with the flag 0x40 */
> > +#define TABLET_MODE_FLAG 0x40
> > +
> >  MODULE_LICENSE("GPL");
> >  MODULE_AUTHOR("AceLan Kao");
> >
> > @@ -42,6 +45,8 @@ static const struct key_entry intel_vbtn_keymap[] = {
> >         { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },          /* volume-up key release */
> >         { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },           /* volume-down key press */
> >         { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } },        /* volume-down key
> release */
> > +       { KE_SW,  0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet mode in */
> > +       { KE_SW,  0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Tablet mode out */
> >         { KE_END },
> >  };
> >
> > @@ -88,6 +93,7 @@ static void notify_handler(acpi_handle handle, u32 event,
> void *context)
> >
> >  static int intel_vbtn_probe(struct platform_device *device)
> >  {
> > +       struct acpi_buffer vgbs_output = { ACPI_ALLOCATE_BUFFER, NULL };
> >         acpi_handle handle = ACPI_HANDLE(&device->dev);
> >         struct intel_vbtn_priv *priv;
> >         acpi_status status;
> > @@ -110,6 +116,22 @@ static int intel_vbtn_probe(struct platform_device
> *device)
> >                 return err;
> >         }
> >
> > +       status = acpi_evaluate_object(handle, "VGBS", NULL, &vgbs_output);
> > +       /* VGBS being present and returning something means
> > +        * we have a tablet mode switch
> > +        */
> > +       if (ACPI_SUCCESS(status)) {
> > +               union acpi_object *obj = vgbs_output.pointer;
> > +
> > +               if (obj && obj->type == ACPI_TYPE_INTEGER) {
> > +                       input_report_switch(priv->input_dev,
> > +                                                               SW_TABLET_MODE,
> > +                                                               !(obj->integer.value & TABLET_MODE_FLAG));
> > +               }
> > +       }
> > +
> > +       kfree(vgbs_output.pointer);
> > +
> >         status = acpi_install_notify_handler(handle,
> >                                              ACPI_DEVICE_NOTIFY,
> >                                              notify_handler,
> > --
> > 2.7.4
> >
> 
> 
> 
> --
> With Best Regards,
> Andy Shevchenko