linux-kernel - Re: [PATCH v3 15/21] fpga: dfl: add fpga bridge platform driver for FME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Feb 2018 16:11:08 +0100
From:   Moritz Fischer <mdf@...nel.org>
To:     Wu Hao <hao.wu@...el.com>
Cc:     Alan Tull <atull@...nel.org>, Moritz Fischer <mdf@...nel.org>,
        linux-fpga@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-api@...r.kernel.org, "Kang, Luwei" <luwei.kang@...el.com>,
        "Zhang, Yi Z" <yi.z.zhang@...el.com>,
        Tim Whisonant <tim.whisonant@...el.com>,
        Enno Luebbers <enno.luebbers@...el.com>,
        Shiva Rao <shiva.rao@...el.com>,
        Christopher Rauer <christopher.rauer@...el.com>
Subject: Re: [PATCH v3 15/21] fpga: dfl: add fpga bridge platform driver for
 FME

Hi Hao,

On Thu, Feb 01, 2018 at 01:15:43PM +0800, Wu Hao wrote:
> On Wed, Jan 31, 2018 at 09:16:58AM -0600, Alan Tull wrote:
> > On Mon, Nov 27, 2017 at 12:42 AM, Wu Hao <hao.wu@...el.com> wrote:
> > 
> > Hi Hao,
> > 
> > One fix below.  Besides that, please add my ack.
> > 
> > > This patch adds fpga bridge platform driver for FPGA Management Engine.
> > > It implements the enable_set call back for fpga bridge.
> > >
> > > Signed-off-by: Tim Whisonant <tim.whisonant@...el.com>
> > > Signed-off-by: Enno Luebbers <enno.luebbers@...el.com>
> > > Signed-off-by: Shiva Rao <shiva.rao@...el.com>
> > > Signed-off-by: Christopher Rauer <christopher.rauer@...el.com>
> > > Signed-off-by: Wu Hao <hao.wu@...el.com>
> > 
> > Acked-by: Alan Tull <atull@...nel.org>
Acked-by: Moritz Fischer <mdf@...nel.org>
> > 
> > > diff --git a/drivers/fpga/fpga-dfl-fme-br.c b/drivers/fpga/fpga-dfl-fme-br.c
> > > new file mode 100644
> > > index 0000000..db2603b
> > > --- /dev/null
> > > +++ b/drivers/fpga/fpga-dfl-fme-br.c
> > > @@ -0,0 +1,87 @@
> > > +/*
> > > + * FPGA Bridge Driver for FPGA Management Engine (FME)
> > > + *
> > > + * Copyright (C) 2017 Intel Corporation, Inc.
> > > + *
> > > + * Authors:
> > > + *   Wu Hao <hao.wu@...el.com>
> > > + *   Joseph Grecco <joe.grecco@...el.com>
> > > + *   Enno Luebbers <enno.luebbers@...el.com>
> > > + *   Tim Whisonant <tim.whisonant@...el.com>
> > > + *   Ananda Ravuri <ananda.ravuri@...el.com>
> > > + *   Henry Mitchel <henry.mitchel@...el.com>
> > > + *
> > > + * This work is licensed under the terms of the GNU GPL version 2.
> > 
> > If we're using the SPDX, then please get rid of the above line.
> > 
> > > + * SPDX-License-Identifier: GPL-2.0
> > > + */
> > 
> > The SPDX line should be the first line of the file with a // (for .c
> > files), please see:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/process/license-rules.rst
> > 
> > Same thing for other files.
> 
> Thanks for the review.
> 
> Sure, will fix this for all driver files in the next version.
> 
> Thanks
> Hao
> 
> > 
> > Alan

Looks good, feel free to add my Acked-by: with fixes Alan requested,

Moritz

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)