linux-kernel - Re: [PATCH] ARM: dts: imx53: use PMIC's TSI pins in adc mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Feb 2018 15:00:34 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Cc:     Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: imx53: use PMIC's TSI pins in adc mode

On Mon, Jan 15, 2018 at 03:28:20PM +0100, Sebastian Reichel wrote:
> PPD uses the PMIC's TSI pins in general purpose ADC mode.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>

s/imx53/imx53-ppd

> ---
>  arch/arm/boot/dts/imx53-ppd.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx53-ppd.dts b/arch/arm/boot/dts/imx53-ppd.dts
> index 123297da43a7..80224fa995f9 100644
> --- a/arch/arm/boot/dts/imx53-ppd.dts
> +++ b/arch/arm/boot/dts/imx53-ppd.dts
> @@ -132,6 +132,14 @@
>  		enable-active-high;
>  	};
>  
> +	reg_tsiref: tsiref {

A better node name should be regulator-tsiref.

> +		compatible = "regulator-fixed";
> +		regulator-name = "tsiref";
> +		regulator-min-microvolt = <2500000>;
> +		regulator-max-microvolt = <2500000>;
> +		regulator-always-on;
> +	};
> +
>  	pwm_bl: backlight {
>  		compatible = "pwm-backlight";
>  		pwms = <&pwm2 0 50000>;
> @@ -295,6 +303,9 @@
>  		interrupts = <12 0x8>;
>  		spi-max-frequency = <1000000>;
>  

This new line can be dropped now.

I fixed up all these, and applied the patch.

Shawn 

> +		dlg,tsi-as-adc;
> +		tsiref-supply = <&reg_tsiref>;
> +
>  		regulators {
>  			buck1_reg: buck1 {
>  				regulator-name = "BUCKCORE";
> -- 
> 2.15.1
>