linux-kernel - Re: Adjustments for a lot of function implementations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Feb 2018 13:30:30 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Hans Verkuil <hverkuil@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, kernel-janitors@...r.kernel.org
Cc:     Julia Lawall <julia.lawall@...6.fr>, Jan Kara <jack@...e.cz>,
        Lorenzo Stoakes <lstoakes@...il.com>,
        Michal Hocko <mhocko@...e.com>,
        Muralidharan Karicheri <mkaricheri@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: Adjustments for a lot of function implementations

> One last time: either post per-driver patches with all the cleanups for a driver
> in a single patch,

I preferred to offer source code adjustments according to specific transformation
patterns mostly for each software module separately (also in small patch series).

> or a per-directory patch (drivers/media/pci, usb, etc) doing the same cleanup
> for all drivers in that directory.

I am curious if bigger patch packages would be easier to get accepted.

Or would you get frightened still by any other change combination?

> I prefer the first approach,

We have got different preferences for a safe patch granularity.

> but it's up to you.

I imagine that there are more development factors involved.

> We don't have the time to wade through dozens of one-liner cleanup patches.

It is usual that integration of update suggestions will take some time.
How would the situation change if I would dare to regroup possible update steps?

> I don't understand what is so difficult about this.

There are communication difficulties to consider since your terse information
from your conference meeting.

If you would insist on patch squashing, would you dare to use a development tool
like “quilt fold” also on your own once more?

Regards,
Markus