linux-kernel - RE: [PATCH V5 12/17] perf evsel: expose perf_missing_features.write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Feb 2018 14:53:42 +0000
From:   "Liang, Kan" <kan.liang@...el.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "wangnan0@...wei.com" <wangnan0@...wei.com>,
        "jolsa@...nel.org" <jolsa@...nel.org>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>,
        "yao.jin@...ux.intel.com" <yao.jin@...ux.intel.com>
Subject: RE: [PATCH V5 12/17] perf evsel: expose
 perf_missing_features.write_backward

> Em Thu, Jan 18, 2018 at 01:26:27PM -0800, kan.liang@...el.com escreveu:
> > From: Kan Liang <kan.liang@...el.com>
> >
> > perf top need it to handle overwrite fallback later.
> >
> > Signed-off-by: Kan Liang <kan.liang@...el.com>
> > ---
> >  tools/perf/util/evsel.c | 5 +++++
> >  tools/perf/util/evsel.h | 2 ++
> >  2 files changed, 7 insertions(+)
> >
> > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index
> > 4eea3b4..1dd3700 100644
> > --- a/tools/perf/util/evsel.c
> > +++ b/tools/perf/util/evsel.c
> > @@ -1670,6 +1670,11 @@ static bool ignore_missing_thread(struct
> perf_evsel *evsel,
> >  	return true;
> >  }
> >
> > +bool is_write_backward_fail(void)
> > +{
> > +	return perf_missing_features.write_backward;
> > +}
> > +
> 
> Humm,  I think we better expose perf_missing_features, i.e. tools using
> 
> 	if (perf_missing_features.write_backward)
> 

It looks good.
Thanks a lot.

Kan

> looks more clear than:
> 
> 	if (is_write_backward_fail())
> 
> This is minor, so I'm doing this myself, please holler if you disagree.
> 
> - Arnaldo
> 
> >  int perf_evsel__open(struct perf_evsel *evsel, struct cpu_map *cpus,
> >  		     struct thread_map *threads)
> >  {
> > diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index
> > 846e416..1f46728 100644
> > --- a/tools/perf/util/evsel.h
> > +++ b/tools/perf/util/evsel.h
> > @@ -448,4 +448,6 @@ int perf_event_attr__fprintf(FILE *fp, struct
> > perf_event_attr *attr,
> >
> >  struct perf_env *perf_evsel__env(struct perf_evsel *evsel);
> >
> > +bool is_write_backward_fail(void);
> > +
> >  #endif /* __PERF_EVSEL_H */
> > --
> > 2.5.5