linux-kernel - Re: [PATCH v11 3/3] mm, x86: display pkey in smaps only if arch supports pkeys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Feb 2018 12:27:27 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Ram Pai <linuxram@...ibm.com>
Cc:     kbuild-all@...org, mpe@...erman.id.au, mingo@...hat.com,
        akpm@...ux-foundation.org, linuxppc-dev@...ts.ozlabs.org,
        linux-mm@...ck.org, x86@...nel.org, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org, dave.hansen@...el.com,
        benh@...nel.crashing.org, paulus@...ba.org,
        khandual@...ux.vnet.ibm.com, aneesh.kumar@...ux.vnet.ibm.com,
        bsingharora@...il.com, hbabu@...ibm.com, mhocko@...nel.org,
        bauerman@...ux.vnet.ibm.com, ebiederm@...ssion.com,
        linuxram@...ibm.com, corbet@....net, arnd@...db.de,
        fweimer@...hat.com, msuchanek@...e.com
Subject: Re: [PATCH v11 3/3] mm, x86: display pkey in smaps only if arch
 supports pkeys

Hi Ram,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.15 next-20180201]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ram-Pai/mm-x86-powerpc-Enhancements-to-Memory-Protection-Keys/20180202-120004
config: x86_64-randconfig-x005-201804 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   In file included from arch/x86/include/asm/mmu_context.h:8:0,
                    from arch/x86/events/core.c:36:
>> include/linux/pkeys.h:16:23: error: expected identifier or '(' before numeric constant
    #define vma_pkey(vma) 0
                          ^
>> arch/x86/include/asm/mmu_context.h:298:19: note: in expansion of macro 'vma_pkey'
    static inline int vma_pkey(struct vm_area_struct *vma)
                      ^~~~~~~~

vim +16 include/linux/pkeys.h

     7	
     8	#ifdef CONFIG_ARCH_HAS_PKEYS
     9	#include <asm/pkeys.h>
    10	#else /* ! CONFIG_ARCH_HAS_PKEYS */
    11	#define arch_max_pkey() (1)
    12	#define execute_only_pkey(mm) (0)
    13	#define arch_override_mprotect_pkey(vma, prot, pkey) (0)
    14	#define PKEY_DEDICATED_EXECUTE_ONLY 0
    15	#define ARCH_VM_PKEY_FLAGS 0
  > 16	#define vma_pkey(vma) 0
    17	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30449 bytes)