[<prev] [next>] [day] [month] [year] [list]
Date: Fri, 2 Feb 2018 21:25:36 +0100
From: SF Markus Elfring <elfring@...rs.sourceforge.net>
To: kernel-janitors@...r.kernel.org,
Arvind Yadav <arvind.yadav.cs@...il.com>,
Sebastian Reichel <sre@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] hsi_char: Delete an error message for a failed memory
allocation in hsc_probe()
From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Fri, 2 Feb 2018 21:21:12 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
drivers/hsi/clients/hsi_char.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c
index cf9c2a332ad8..9d2a6d64dfb8 100644
--- a/drivers/hsi/clients/hsi_char.c
+++ b/drivers/hsi/clients/hsi_char.c
@@ -697,10 +697,9 @@ static int hsc_probe(struct device *dev)
int i;
cl_data = kzalloc(sizeof(*cl_data), GFP_KERNEL);
- if (!cl_data) {
- dev_err(dev, "Could not allocate hsc_client_data\n");
+ if (!cl_data)
return -ENOMEM;
- }
+
hsc_baseminor = HSC_BASEMINOR(hsi_id(cl), hsi_port_id(cl));
if (!hsc_major) {
ret = alloc_chrdev_region(&hsc_dev, hsc_baseminor,
--
2.16.1
Powered by blists - more mailing lists