linux-kernel - Re: [PATCH v12 1/3] lib: Add strongly typed 64bit int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 4 Feb 2018 10:19:18 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Crt Mori <cmo@...exis.com>, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Rusty Russell <rusty@...tcorp.com.au>,
        Ian Abbott <abbotti@....co.uk>,
        Larry Finger <Larry.Finger@...inger.net>,
        Niklas Soderlund <niklas.soderlund+renesas@...natech.se>,
        Thomas Gleixner <tglx@...utronix.de>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kernel@...r.kernel.org,
        Linux Iio <linux-iio@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        David Laight <David.Laight@...lab.com>
Subject: Re: [PATCH v12 1/3] lib: Add strongly typed 64bit int_sqrt

On Mon, 15 Jan 2018 02:36:15 -0800
Joe Perches <joe@...ches.com> wrote:

> On Wed, 2018-01-10 at 09:37 +0100, Crt Mori wrote:
> > Shouldn't I rather make it
> > 
> >          if (x <= ULONG_MAX)
> >                  return int_sqrt((unsigned long) x);  
> 
> With this change: (I believe done in v13) and
> as requested by Crt Mori in a private email:
> 
> Acked-by: Joe Perches <joe@...ches.com>

Thanks Joe,

I've applied v13 which indeed does have this change.
Applied to the togreg branch of iio.git where it will sit until after
the merge window.

For now I'll only be pushing that out as a build test branch so
still time for improvements without having to revert or anything.

Thanks,

Jonathan

>