linux-kernel - Re: [PATCH] cifs: silence compiler warnings showing up with gcc-8.0.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 3 Feb 2018 19:27:43 -0600
From:   Steve French <smfrench@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Steve French <sfrench@...ba.org>,
        Martin Sebor <msebor@....gnu.org>,
        Pavel Shilovsky <pshilov@...rosoft.com>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Aurelien Aptel <aaptel@...e.com>,
        Long Li <longli@...rosoft.com>,
        Samuel Cabrero <scabrero@...e.de>,
        Sachin Prabhu <sprabhu@...hat.com>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: silence compiler warnings showing up with gcc-8.0.0

merged into cifs-2.6.git for-next

On Fri, Feb 2, 2018 at 9:48 AM, Arnd Bergmann <arnd@...db.de> wrote:
> This bug was fixed before, but came up again with the latest
> compiler in another function:
>
> fs/cifs/cifssmb.c: In function 'CIFSSMBSetEA':
> fs/cifs/cifssmb.c:6362:3: error: 'strncpy' offset 8 is out of the bounds [0, 4] [-Werror=array-bounds]
>    strncpy(parm_data->list[0].name, ea_name, name_len);
>
> Let's apply the same fix that was used for the other instances.
>
> Fixes: b2a3ad9ca502 ("cifs: silence compiler warnings showing up with gcc-4.7.0")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  fs/cifs/cifssmb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
> index 72d71703f1e8..78bc86c315ec 100644
> --- a/fs/cifs/cifssmb.c
> +++ b/fs/cifs/cifssmb.c
> @@ -6343,9 +6343,7 @@ CIFSSMBSetEA(const unsigned int xid, struct cifs_tcon *tcon,
>         pSMB->InformationLevel =
>                 cpu_to_le16(SMB_SET_FILE_EA);
>
> -       parm_data =
> -               (struct fealist *) (((char *) &pSMB->hdr.Protocol) +
> -                                      offset);
> +       parm_data = (void *)pSMB + offsetof(struct smb_hdr, Protocol) + offset;
>         pSMB->ParameterOffset = cpu_to_le16(param_offset);
>         pSMB->DataOffset = cpu_to_le16(offset);
>         pSMB->SetupCount = 1;
> --
> 2.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks,

Steve