linux-kernel - Re: [PATCH -next] meson-gx-socinfo: make local function meson_gx_socinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Feb 2018 13:25:19 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Carlo Caione <carlo@...one.org>,
        Kevin Hilman <khilman@...libre.com>,
        Arnaud Patard <arnaud.patard@...-net.org>
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] meson-gx-socinfo: make local function
 meson_gx_socinfo_init static

On 10/01/2018 15:19, Wei Yongjun wrote:
> Fixes the following sparse warnings:
> 
> drivers/soc/amlogic/meson-gx-socinfo.c:100:12: warning:
>  symbol 'meson_gx_socinfo_init' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/soc/amlogic/meson-gx-socinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
> index f2d8c3c..ea091f1 100644
> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
> @@ -97,7 +97,7 @@ static const char *socinfo_to_soc_id(u32 socinfo)
>  	return "Unknown";
>  }
>  
> -int __init meson_gx_socinfo_init(void)
> +static int __init meson_gx_socinfo_init(void)
>  {
>  	struct soc_device_attribute *soc_dev_attr;
>  	struct soc_device *soc_dev;
> 
> 
> 

Acked-by: Neil Armstrong <narmstrong@...libre.com>