linux-kernel - Re: [PATCH] Resolve RF Type mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Feb 2018 13:51:11 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Kangmin Park <l4stpr0gr4m@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        arnd@...db.de, linux-kernel@...r.kernel.org, justin@...eeland.com,
        davem@...emloft.net, hdegoede@...hat.com, hadess@...ess.net,
        joe@...ches.com, Larry.Finger@...inger.net
Subject: Re: [PATCH] Resolve RF Type mismatch

On Wed, Feb 07, 2018 at 12:57:13AM +0900, Kangmin Park wrote:
> From: pr0gr4m <l4stpr0gr4m@...il.com>

No changelog, no sign-off.  Changelogs are required but especially in
this case, it's not immediately obvious what this patch is about.

This patch has unrelated white space changes as well.  Here is how the
rules work:

> -	ODM_1T1R	=	0,
> +	ODM_1T1R		=	0,

This are unrelated.

This white space change is on the same line so that's fine (it's
related).

> -	else if ((rf_type == RF_1T2R) || (rf_type ==RF_2T2R))
> +	else if ((rf_type == RF_1T2R) || (rf_type == RF_2T2R) || (rf_type == RF_2T2R_GREEN))

regards,
dan carpenter