linux-kernel - Re: [PATCH] platform/x86: dell-laptop: Removed duplicates in DMI whitelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Feb 2018 16:20:34 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexander Abrosimov <alexander.n.abrosimov@...il.com>
Cc:     Matthew Garrett <mjg59@...f.ucam.org>,
        Pali Rohár <pali.rohar@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Mario Limonciello <mario.limonciello@...l.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-laptop: Removed duplicates in DMI whitelist

On Thu, Feb 8, 2018 at 12:12 AM, Alexander Abrosimov
<alexander.n.abrosimov@...il.com> wrote:
> Fixed a mistake in which several entries were duplicated in the DMI list
> from the below commit
> fe486138 platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
>

Pushed to my review and testing queue, thanks!

(Would be material for v4.17 cycle)

> Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov@...il.com>
> ---
>  drivers/platform/x86/dell-laptop.c | 18 ------------------
>  1 file changed, 18 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index a7b141992cb3..a66a6a6e47b9 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -125,28 +125,10 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
>                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>                         DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
>                 },
>         },
>         {
> -               .matches = {
> -                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> -                       DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> -               },
> -       },
> -       {
> -               .matches = {
> -                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> -                       DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> -               },
> -       },
> -       {
> -               .matches = {
> -                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> -                       DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> -               },
> -       },
> -       {
>                 .ident = "Dell Computer Corporation",
>                 .matches = {
>                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
>                         DMI_MATCH(DMI_CHASSIS_TYPE, "8"),
>                 },
> --
> 2.13.6
>



-- 
With Best Regards,
Andy Shevchenko