linux-kernel - Re: [PATCH 3/3] auxdisplay: charlcd: replace octal literal with form-feed escape sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 10 Feb 2018 10:43:49 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Robert Abel <rabel@...ertabel.eu>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] auxdisplay: charlcd: replace octal literal with
 form-feed escape sequence

On Sat, Feb 10, 2018 at 12:50 AM, Robert Abel <rabel@...ertabel.eu> wrote:
> There is no need to resort to octal escape sequence for the form feed character when an established escape sequence exists.
>
> Signed-off-by: Robert Abel <rabel@...ertabel.eu>
> ---
>  drivers/auxdisplay/charlcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c
> index 92549c8344a4..a3486db03d81 100644
> --- a/drivers/auxdisplay/charlcd.c
> +++ b/drivers/auxdisplay/charlcd.c
> @@ -555,7 +555,7 @@ static void charlcd_write_char(struct charlcd *lcd, char c)
>                         /* back one char again */
>                         lcd->ops->write_cmd(lcd, LCD_CMD_SHIFT);
>                         break;
> -               case '\014':
> +               case '\f':

Normally I wouldn't bother with this kind of change, but since the
other switch cases all use escape sequences, this improves
consistency, so agreed.

Trivial. Compile-tested.

Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>

>                         /* quickly clear the display */
>                         charlcd_clear_fast(lcd);
>                         break;
> --
> 2.11.0
>