linux-kernel - Re: [PATCH 16/20] auxdisplay: img-ascii-lcd: Remove MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 10 Feb 2018 15:19:36 +0100
From:   Ulf Magnusson <ulfalizer@...il.com>
To:     James Hogan <james@...anarts.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, linux-kbuild@...r.kernel.org,
        tfiga@...omium.org, paul.burton@...s.com, m.szyprowski@...sung.com,
        egtvedt@...fundet.no, Linus Walleij <linus.walleij@...aro.org>,
        Vineet Gupta <vgupta@...opsys.com>,
        Mel Gorman <mgorman@...hsingularity.net>, hch@....de,
        mina86@...a86.com, robh@...nel.org,
        Stephen Boyd <sboyd@...eaurora.org>, paulus@...abs.org,
        Will Deacon <will.deacon@....com>, tony@...mide.com,
        npiggin@...il.com, Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>
Subject: Re: [PATCH 16/20] auxdisplay: img-ascii-lcd: Remove MIPS_SEAD3 dep.

On Thu, Feb 08, 2018 at 05:35:30PM +0000, James Hogan wrote:
> On 5 February 2018 at 01:21, Ulf Magnusson <ulfalizer@...il.com> wrote:
> > The MIPS_SEAD3 symbol was removed in commit 64601cb1343f ("leds: Remove SEAD-3
> > driver").
> >
> > Remove the MIPS_SEAD3 dependency from IMG_ASCII_LCD.
> 
> Its not a dependency, just a default (presumably so that existing
> kernel configs get updated automatically).

Note that it appears in the default's condition rather than as part of
the default value.

Undefined Kconfig symbols always evaluate to n in a tristate state,
regardless of whether they're given a user value in a .config file or
not, so this is a no-op as far as Kconfig in concerned.

The motivation in the original commit message was a bit lackluster
though. I've submitted a v2.

> 
> Note that sead3 now uses MIPS_GENERIC (or more specifically
> CONFIG_LEGACY_BOARD_SEAD3), but this driver is enabled in the config
> snippets, e.g.:
> arch/mips/configs/generic/board-sead-3.config
> arch/mips/configs/generic/board-boston.config
> 
> so indeed there is no real need to replace MIPS_SEAD3 with anything here.
> 
> Cheers
> James
> 
> >
> > Discovered with the
> > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> > script.
> >
> > Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
> > ---
> >  drivers/auxdisplay/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > index 2c2ed9cf8796..3cba78d36eec 100644
> > --- a/drivers/auxdisplay/Kconfig
> > +++ b/drivers/auxdisplay/Kconfig
> > @@ -137,7 +137,7 @@ config CFAG12864B_RATE
> >  config IMG_ASCII_LCD
> >         tristate "Imagination Technologies ASCII LCD Display"
> >         depends on HAS_IOMEM
> > -       default y if MIPS_MALTA || MIPS_SEAD3
> > +       default y if MIPS_MALTA
> >         select SYSCON
> >         help
> >           Enable this to support the simple ASCII LCD displays found on
> > --
> > 2.14.1
> >
> 
> 
> 
> -- 
> James Hogan

Cheers,
Ulf