linux-kernel - Re: Software evolution around “checkpatch.pl”?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 10 Feb 2018 19:30:15 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Joe Perches <joe@...ches.com>,
        Jonathan Cameron <jic23@...23.retrosnub.co.uk>,
        linux-iio@...r.kernel.org, linux-input@...r.kernel.org
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Jiri Kosina <jikos@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: Software evolution around “checkpatch.pl”?

>> So I think checkpatch is striking the right balance here in
>> how it warns.  Obviously if it could assess the text
>> and come to an informed decision that would be great but
>> we are some way from that ;)
> 
> The 'informed' bit is difficult as it is mostly a political problem.

I find such a view very interesting.


> I just wish Markus would improve his consistently terrible commit messages

I tried to achieve another clarification a few times.


> that just restate the action being done and detail
> _why_ a particular thing _should_ be done.

Unfortunately, it seems that no other contributors picked
corresponding opportunities up so far.

You indicated also special software development challenges in your commit
“checkpatch: attempt to find unnecessary 'out of memory' messages”.

https://lkml.org/lkml/2014/6/10/382
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ebfdc40969f24fc0cdd1349835d36e8ebae05374


> His acceptance rate would improve as many of these back and forth
> replies for what trivialities he posts as patches would be minimized.

My selection of change possibilities leads to mixed integration results.

I stumbled on variations for general change resistance.

Regards,
Markus